script_interface: require all BreakageSpec parameters (bug-sweep #42)#5368
Draft
RudolfWeeber wants to merge 1 commit into
Draft
script_interface: require all BreakageSpec parameters (bug-sweep #42)#5368RudolfWeeber wants to merge 1 commit into
RudolfWeeber wants to merge 1 commit into
Conversation
BreakageSpec registered breakage_length and action_type via AutoParameters but did not override do_construct, so the inherited ObjectHandle::do_construct only set the parameters actually passed. Omitting breakage_length left the core struct's value-initialized 0.0 in place; since the breakage check is `distance >= spec.breakage_length`, that is always true and queues every bond of that type for breakage on the first execute(), silently deleting them. 0.0 is a legitimate, tested breakage_length, so it cannot serve as an unset sentinel. Following the established bonded-interaction convention (ScriptInterface::Interactions::BondedInteraction::check_valid_parameters), add a do_construct override that wraps construction in parallel_try_catch and throws "Parameter '<name>' is missing" if any valid parameter is absent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BreakageSpec registered breakage_length and action_type via AutoParameters
but did not override do_construct, so the inherited ObjectHandle::do_construct
only set the parameters actually passed. Omitting breakage_length left the
core struct's value-initialized 0.0 in place; since the breakage check is
distance >= spec.breakage_length, that is always true and queues every bondof that type for breakage on the first execute(), silently deleting them.
0.0 is a legitimate, tested breakage_length, so it cannot serve as an unset
sentinel. Following the established bonded-interaction convention
(ScriptInterface::Interactions::BondedInteraction::check_valid_parameters),
add a do_construct override that wraps construction in parallel_try_catch and
throws "Parameter '' is missing" if any valid parameter is absent.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
🤖 Generated with Claude Code