cluster_analysis: fix fractal_dimension missing-dr error and docs (bug-sweep #51)#5374
Draft
RudolfWeeber wants to merge 1 commit into
Draft
cluster_analysis: fix fractal_dimension missing-dr error and docs (bug-sweep #51)#5374RudolfWeeber wants to merge 1 commit into
RudolfWeeber wants to merge 1 commit into
Conversation
…g-sweep #51) The Cluster docstring advertised fractal_dimension(dr=None), but dr is a mandatory parameter (the histogram bin increment) and no layer materializes a default. Calling fractal_dimension() with no argument made the script interface do an unconditional parameters.at("dr"), throwing an opaque std::out_of_range that surfaced to Python as 'IndexError: unordered_map::at'. Fix: - Cluster.hpp: use the named get_value overload get_value<double>(parameters, "dr") so an omitted dr raises the standard, friendly Exception("Parameter 'dr' is missing.") instead of an opaque std::out_of_range. - cluster_analysis.py: correct the docstring signature to fractal_dimension(dr), removing the false promise of an optional/None default. Adds a regression test (test_fractal_dimension_requires_dr) asserting that omitting dr raises the friendly 'Parameter dr is missing' error and that dr=None raises a clear 'not convertible to double' conversion error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cluster docstring advertised fractal_dimension(dr=None), but dr is a
mandatory parameter (the histogram bin increment) and no layer materializes
a default. Calling fractal_dimension() with no argument made the script
interface do an unconditional parameters.at("dr"), throwing an opaque
std::out_of_range that surfaced to Python as 'IndexError: unordered_map::at'.
Fix:
"dr") so an omitted dr raises the standard, friendly
Exception("Parameter 'dr' is missing.") instead of an opaque
std::out_of_range.
fractal_dimension(dr), removing the false promise of an optional/None
default.
Adds a regression test (test_fractal_dimension_requires_dr) asserting that
omitting dr raises the friendly 'Parameter dr is missing' error and that
dr=None raises a clear 'not convertible to double' conversion error.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
🤖 Generated with Claude Code