Skip to content

magnetostatics: require 'prefactor' for DipolarP3M (bug-sweep #55) #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RudolfWeeber wants to merge 1 commit into
base: python
Choose a base branch
from
+5 −1
Draft

magnetostatics: require 'prefactor' for DipolarP3M (bug-sweep #55) #5378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/espressomd/magnetostatics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def validate_params(self, params):
raise TypeError("Parameter 'tune' has to be a boolean")

def required_keys(self):
return {"accuracy"}
return {"prefactor", "accuracy"}

def default_params(self):
return {"cao": -1,
Expand Down
4 changes: 4 additions & 0 deletions testsuite/python/dipolar_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ def test_exceptions_p3m(self):
MDLC = espressomd.magnetostatics.DLC
dp3m_params = dict(prefactor=1., epsilon=0.1, accuracy=1e-6,
mesh=[49, 49, 49], cao=7, r_cut=4.5, alpha=0.9)
with self.assertRaisesRegex(RuntimeError, "Parameter 'prefactor' is missing"):
espressomd.magnetostatics.DipolarP3M(
**{key: value for key, value in dp3m_params.items()
if key != 'prefactor'})
with self.assertRaisesRegex(ValueError, "Parameter 'prefactor' must be > 0"):
espressomd.magnetostatics.DipolarP3M(
**{**dp3m_params, 'prefactor': -2.})
Expand Down
Loading