Repository navigation
fix(ci): remove --disable-discovery from the reth extra args - #167
Merged
Merged
Conversation
ethereum-package adds --disable-discv4-discovery to the reth command. The current ethpandaops/reth:main image does not start when it also gets --disable-discovery. The CI sync test then fails before the run. The test runs for 2 minutes only, so peer discovery has no effect on the result. Keep --full to test the extra args.
![redpandabot[bot]](https://avatars.githubusercontent.com/in/3749543?s=60&v=4){kind=small}
There was a problem hiding this comment.
Removes the conflicting --disable-discovery flag from the reth el-extra-args in the CI action workflow, fixing the reth startup failure; --full is kept so extra-args are still exercised. The other workflow (full-sync-test.yaml) already passes only --full for reth, so this makes the two consistent. No issues found.
Reviewed 1 changed file(s) @ eadd200d — no blocking issues found.
"He who digs a pit for others falls into it himself." — Eastern European proverb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI sync test fails because the reth service does not start:
ethereum-package adds
--disable-discv4-discoveryto the reth command. The CI workflow also passes--disable-discoveryinel-extra-args. The currentethpandaops/reth:mainimage rejects the two flags together.Failed run: https://github.com/ethpandaops/syncoor/actions/runs/39565650706/job/119107664209
Fix
Remove
--disable-discoveryfromel-extra-argsin.github/workflows/ci.action.yaml. The test runs for 2 minutes only, so peer discovery has no effect on the result. The--fullflag stays to test the extra args.