Include ref.parent matches in events by-reference navigation#2280
ref.parent matches in events by-reference navigation#2280Conversation
|
|
ref.parent matches in events by-reference navigation
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
e666187 to
8f5e641
Compare
# Conflicts: # src/Exceptionless.Web/Controllers/EventController.cs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3cc52eb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f152edde5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 775c14f17c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0dd46364
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return `reference:${quoteIfSpecialCharacters(this.value)}`; | ||
| const reference = quoteIfSpecialCharacters(this.value); | ||
| return `(reference:${reference} OR ref.parent:${reference})`; |
There was a problem hiding this comment.
When this filter is used on the events route, (app)/+layout.svelte calls filterUsesPremiumFeatures() on the filter query string, and premium-filter.ts still treats any ref.parent field as premium because its free-field list only contains reference/reference_id. For free-plan organizations, clicking a Reference filter or the by-ref page's “View In Events” link now shows the premium-upgrade notification even though the backend validator intentionally made parent-reference lookup free; the client free-field list needs the same ref.parent allowance.
Useful? React with 👍 / 👎.
|
/events/by-ref/{referenceId}only matchedreference:{id}, so child events that stored their relationship inref.parentcould not be reached through Parent navigation.Root cause
referencefield.ref.parentto the query initially made the route premium-only because dynamic reference fields were classified as premium.idx.parent-reven though test fixtures did.Changes
reference:{id}orref.parent:{id}in organization- and project-scoped handlers and frontend navigation.@ref:parentfor free-plan events; arbitrary custom data remains unindexed.idx.parent-rvalues for retained events without overwriting existing indexes.ref.<name>query fields.ref.<name>and suppress unsafe/invalid filter controls.origin/maininto the PR branch.Verification
dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore --disable-build-servers -m:1— 0 warnings, 0 errors.StringExtensionsTests— 43 passed.PersistentEventQueryValidatorTests— 70 passed.EventPipelineTests— 60 passed, 1 intentional skip.EventEndpointTests— 104 passed.BackfillParentReferencesMigrationTests— passed against Elasticsearch.npm run validate— passed (Prettier, ESLint, and Svelte check with 0 errors/warnings).dotnet format --verify-no-changes— passed.Compatibility and scope
identifierroute constraint and event validation to 8–100 letters, digits, or hyphens.idx.parent-rsearch field; arbitrary dynamic reference fields remain premium-only.