Fix legacy stack saved view comparison#2402
Merged
Merged
Conversation
ejsmith
marked this pull request as ready for review
July 25, 2026 21:56
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Follow-up to the post-merge review feedback on #2396: stack saved views created before Project and Tags columns existed omit those keys. The table hydrates both defaults as
false, but the saved-view comparison previously did not receive the same defaults, so legacy views appeared modified immediately and Reset to Saved could not clear that state.Review thread: #2396 (comment)
Verification
npx vitest run src/lib/features/saved-views/use-saved-views.test.ts(39 passed)npm run validateBreaking changes
None.