-
Notifications
You must be signed in to change notification settings - Fork 176
Add pre-commit hooks #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks #688
Changes from 1 commit
9dcfff9
925d588
f81ebee
0e68c85
782067f
0c2ebef
3e0be71
d565cf2
a2b5772
12e36f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,6 @@ | ||
| --- | ||
| name: Team Meeting 📅 | ||
| about: A team meeting | ||
| title: 'EBP Team Meeting - {{ MONTH }}' | ||
| labels: meeting | ||
| assignees: '' | ||
| --- | ||
| ______________________________________________________________________ | ||
|
|
||
| ## name: Team Meeting 📅 about: A team meeting title: 'EBP Team Meeting - {{ MONTH }}' labels: meeting assignees: '' | ||
|
|
||
| Hello @executablebooks/ebpteam! This is an issue to track the next Executable Books team meeting! Here's some relevant information: | ||
|
|
||
|
|
@@ -16,11 +12,11 @@ If you'd like to discuss something at the meeting, please add an item to the age | |
|
|
||
| ### Before the meeting | ||
|
|
||
| - [ ] Update dates and make sure HackMD information is correct. | ||
| - [ ] Team members add agenda items. | ||
| - \[ \] Update dates and make sure HackMD information is correct. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. broken the todo lists |
||
| - \[ \] Team members add agenda items. | ||
|
|
||
| ### After the meeting | ||
|
|
||
| - [ ] Turn any follow-ups into issues/comments/etc. | ||
| - [ ] Copy the meeting notes to the docs. | ||
| - [ ] Remove notes and clean up HackMD. | ||
| - \[ \] Turn any follow-ups into issues/comments/etc. | ||
| - \[ \] Copy the meeting notes to the docs. | ||
| - \[ \] Remove notes and clean up HackMD. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ on: | |
| # every day at 1:00 | ||
| - cron: '0 1 * * *' | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| jobs: | ||
| docs: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Install pre-commit hooks via | ||
| # pre-commit install | ||
|
|
||
| exclude: > | ||
| (?x)^( | ||
| \.vscode/settings\.json| | ||
| )$ | ||
| repos: | ||
|
|
||
| - repo: git://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.1.0 | ||
| hooks: | ||
| - id: check-toml | ||
| - id: check-json | ||
| - id: check-yaml | ||
| - id: end-of-file-fixer | ||
| - id: trailing-whitespace | ||
|
|
||
| - repo: https://github.com/psf/black | ||
| rev: 22.1.0 | ||
| hooks: | ||
| - id: black | ||
|
|
||
| - repo: https://github.com/executablebooks/mdformat | ||
| rev: 0.7.13 | ||
| hooks: | ||
| - id: mdformat | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeh so you need to use this with plugins 😉 e.g.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ahh ok, I will try to give that a shot
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ahhhh, ok I will take a look and figure it out
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Meaning to circle back to mdformat-myst at some point and do some more testing/improvements. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,4 @@ ul.postlist > li > p:first-child { | |
|
|
||
| .landing-grid .sd-card-header { | ||
| background-color: #f3772638; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
| (feature-note)= | ||
|
|
||
| # Feature voting board | ||
|
|
||
| You can help us to prioritise development of new features by leaving a [👍 reaction](https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) on the first comment of any `enhancement` issue. | ||
|
|
||
| Below is a list of all current enhancement issues from our core repositories,[^a] ordered by 👍 | ||
| Below is a list of all current enhancement issues from our core repositories,\[^a\] ordered by 👍 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. broken the footnotes
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. argh - hmm what should we do about these? add exceptions in the mdformat config or something? If this is gonna cause headaches like this then I'd vote we just don't use mdformat 🤷
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. plugins 👇 |
||
| Click the `+` to see more details. | ||
|
|
||
| [^a]: The data in this table is updated every day. | ||
| \[^a\]: The data in this table is updated every day. | ||
|
|
||
| <div class="full-width"> | ||
|
|
||
|
|
@@ -16,6 +17,7 @@ Click the `+` to see more details. | |
| </div> | ||
|
|
||
| <!-- DataTables to make the table above look nice --> | ||
|
|
||
| <link rel="stylesheet" | ||
| href="https://cdn.datatables.net/1.10.24/css/jquery.dataTables.min.css"> | ||
| <script type="text/javascript" src="https://cdn.datatables.net/1.10.24/js/jquery.dataTables.min.js"></script> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken the front matter