Skip to content

Memory save stores "the user" instead of the user's name ("Priya, the user's sister, lives in Mumbai") #475

Closed

Description

@itsskofficial

Seen while testing #471 (#463) on qwen3:8b: the memory-save tool stored "Priya, the user's sister, lives in Mumbai." instead of using the user's name ("Priya, Maya Rao's sister…"). Memories that say "the user" read oddly on the Memory screen, and they're harder for the subject matching from #471 to tie to the user.

Fix: when a fact is saved, replace "the user" / "the user's" with the user's configured name (and handle "user's"), the way other places substitute the name. Add tests.

Done when: a test saving "Priya, the user's sister, lives in Mumbai" stores "Priya, Maya Rao's sister, lives in Mumbai".

Activity

  1. added
    bugSomething isn't working
    area: memoryFacts, user model, nightly consolidation
    priority: P2Later: useful, lower urgency
    size: SSmall: a few days
    on Oct 18, 2026
  2. Tanmay-Ts commented on Oct 18, 2026

    @Tanmay-Ts
    Contributor

    /assign

  3. github-actions commented on Oct 18, 2026

    @github-actions

    @Tanmay-Ts Assigned to you. Open a PR within a week or comment if you need more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: memoryFacts, user model, nightly consolidationbugSomething isn't workinggood first issueGood for newcomerspriority: P2Later: useful, lower urgencysize: SSmall: a few days

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions