Skip to content

fix: send raw ArrayBuffer as binary instead of JSON - #7453

Closed
dajiaohuang wants to merge 1 commit into
expressjs:masterfrom
dajiaohuang:fix/7362-arraybuffer-binary
Closed

dajiaohuang wants to merge 1 commit into
expressjs:masterfrom
dajiaohuang:fix/7362-arraybuffer-binary

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

Fixes #7362

res.send(ArrayBuffer) was sending {} with Content-Type: application/json because ArrayBuffer.isView() returns false for raw ArrayBuffer, causing it to fall through to this.json().

Problem

ArrayBuffer.isView() only returns true for TypedArray views (like Uint8Array), but raw ArrayBuffer is not a view, so it falls through to this.json(chunk) producing {}.

Solution

Add instanceof ArrayBuffer check to handle raw ArrayBuffer like TypedArray views:

  • Set Content-Type to 'bin' (binary)
  • Convert ArrayBuffer to Buffer before sending

Verification

res.send(new ArrayBuffer(10))
// Before: {} with Content-Type: application/json
// After: 10 zero bytes with Content-Type: application/octet-stream

Fixes expressjs#7362

res.send(ArrayBuffer) was sending {} because ArrayBuffer.isView() returns
false for raw ArrayBuffer, causing it to fall through to this.json().

This adds an instanceof ArrayBuffer check to handle raw ArrayBuffer like
TypedArray views - setting Content-Type to 'bin' and converting to Buffer.
@krzysdz

krzysdz commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Duplicate of #7363

@krzysdz krzysdz marked this as a duplicate of #7363 Sep 3, 2026
@krzysdz krzysdz closed this Sep 3, 2026
stvwng added a commit to stvwng/cd14715-claude-code-classroom-1 that referenced this pull request Sep 6, 2026
Every report in reports/ is now produced by the current orchestrator, which no
longer bypasses SDK permissions. Previously the four expressjs/express reports
predated that change; only the octocat one had been refreshed by the verification
run.

This also serves as a broader check that removing permissionMode
'bypassPermissions' and allowDangerouslySkipPermissions did not degrade behaviour
across a range of pull requests. It did not: all four runs completed normally, each
spawned all three subagents through the Task tool, and no run stalled waiting on a
permission prompt.

  octocat/Hello-World#1     59/100   1 file   3 subagent runs
  expressjs/express#7453    88/100   1 file   3 subagent runs   clean fix
  expressjs/express#7451    82/100   2 files  6 subagent runs   fix with tests
  expressjs/express#7446    72/100   1 file   3 subagent runs   error handling
  expressjs/express#7435    65/100   3 files  9 subagent runs   multi-file feature

Scores shifted from the previous set (90/64/66/71) because agent output is
non-deterministic; the spread is normal run-to-run variance, not a behavioural
change. #7435 selected three files this time rather than five, which is within the
--max-files 5 cap. README and SUBMISSION_NOTES tables updated to match.

Verified across all 18 files: valid JSON, every finding carries a positive integer
line number, all three subagents present in every trace, HTML parses with balanced
tags, Markdown fences balanced, Mermaid trace embedded throughout.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AssyVR3HQdtvVAFZ8pRVP3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

res.send(ArrayBuffer) silently sends {} as JSON

2 participants