Repository navigation
fix: send raw ArrayBuffer as binary instead of JSON - #7453
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Fixes expressjs#7362 res.send(ArrayBuffer) was sending {} because ArrayBuffer.isView() returns false for raw ArrayBuffer, causing it to fall through to this.json(). This adds an instanceof ArrayBuffer check to handle raw ArrayBuffer like TypedArray views - setting Content-Type to 'bin' and converting to Buffer.
Contributor
|
Duplicate of #7363 |
stvwng
added a commit
to stvwng/cd14715-claude-code-classroom-1
that referenced
this pull request
Sep 6, 2026
Every report in reports/ is now produced by the current orchestrator, which no longer bypasses SDK permissions. Previously the four expressjs/express reports predated that change; only the octocat one had been refreshed by the verification run. This also serves as a broader check that removing permissionMode 'bypassPermissions' and allowDangerouslySkipPermissions did not degrade behaviour across a range of pull requests. It did not: all four runs completed normally, each spawned all three subagents through the Task tool, and no run stalled waiting on a permission prompt. octocat/Hello-World#1 59/100 1 file 3 subagent runs expressjs/express#7453 88/100 1 file 3 subagent runs clean fix expressjs/express#7451 82/100 2 files 6 subagent runs fix with tests expressjs/express#7446 72/100 1 file 3 subagent runs error handling expressjs/express#7435 65/100 3 files 9 subagent runs multi-file feature Scores shifted from the previous set (90/64/66/71) because agent output is non-deterministic; the spread is normal run-to-run variance, not a behavioural change. #7435 selected three files this time rather than five, which is within the --max-files 5 cap. README and SUBMISSION_NOTES tables updated to match. Verified across all 18 files: valid JSON, every finding carries a positive integer line number, all three subagents present in every trace, HTML parses with balanced tags, Markdown fences balanced, Mermaid trace embedded throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AssyVR3HQdtvVAFZ8pRVP3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7362
res.send(ArrayBuffer) was sending {} with Content-Type: application/json because ArrayBuffer.isView() returns false for raw ArrayBuffer, causing it to fall through to this.json().
Problem
ArrayBuffer.isView()only returns true for TypedArray views (likeUint8Array), but rawArrayBufferis not a view, so it falls through tothis.json(chunk)producing{}.Solution
Add
instanceof ArrayBuffercheck to handle raw ArrayBuffer like TypedArray views:Verification