Repository navigation
build(deps-dev): bump supertest from 6.3.0 to 7.3.0 - #7494
Conversation
Signed-off-by: Noritaka Kobayashi <arukimedesu1166777@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@bjohansebas I forgot to request changes, but the latest supertest works without additional changes. forwardemail/superagent#1816 was fixed in forwardemail/superagent@5663802 (released in Can you revert this and push just the |
For a quick merge, someone else needs to open the PR; otherwise, I’ll be blocked by the repo rules |
|
Oh, there's also another problem - supertest 7.3.1 introduced a regression (forwardemail/supertest#911), which makes the CI fail, so it'd have to be pinned to 7.3.0. |
|
I'll create a PR with just a revert and maybe let's wait until the new regression is fixed, before updating |
Summary
^6.3.0to^7.3.0...or%2e%2eunchanged. SuperAgent otherwise normalizes these paths before Express receives them.Related PR
This is an alternative to #6856. Both PRs address URL normalization in the newer SuperAgent version used by SuperTest 7. This approach keeps the affected tests short by sharing the path handling in
test/support/utils.js.The helper uses SuperAgent's
requestevent to access the underlying Node request and set its path.Testing
npm run lint— passednpm run test-ci— 1,261 tests passed in a local run