Repository navigation
fix(res.redirect): add Content-Length only if Transfer-Encoding is not present - #7507
Closed
kgeminicdev wants to merge 1 commit into
Closed
kgeminicdev wants to merge 1 commit into
kgeminicdev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7506
res.redirect()always setContent-Length, even whenTransfer-Encodingwas already set. That's the same conflict #4893 fixed forres.send(), and Node's HTTP client rejects such responses (Parse Error: Content-Length can't be present with Transfer-Encoding).This applies the same guard as
res.send():Content-Lengthis only set when there is noTransfer-Encodingheader. The status,Locationheader and body are unchanged.Tests: added a case to
test/res.redirect.js. It fails onmasterwith the parse error above and passes with this change. The full suite passes (1262 passing) andnpm run lintis clean.