Repository navigation
fix: avoid JSON serialization error in res.status for BigInt and other values - #7521
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
…r values When res.status() or res.sendStatus() received a BigInt (or other values that JSON.stringify cannot serialize), the error message construction would throw: TypeError: Do not know how to serialize a BigInt This obscured the actual intended error message about invalid status code. The fix replaces JSON.stringify() with String() in error messages to safely convert any value to a string representation. Before: res.sendStatus(200n) // throws: TypeError: Do not know how to serialize a BigInt After: res.sendStatus(200n) // throws: TypeError: Invalid status code: 200. Status code must be an integer. Fixes expressjs#6756
Contributor
|
Duplicate of #6848 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes res.status handling for BigInt and other values that cannot be JSON serialized.\n\nThe branch contains the focused fix committed as cb9ae7d.