Repository navigation
Conversation
Signed-off-by: NUAAwqy <146524024+NUAAwqy@users.noreply.github.com>
subhiandrews
left a comment
There was a problem hiding this comment.
code-check review
No issues found.
Incomplete: no usable output from skeptic; this review is not approved.
Reviewed with code-check · Apache-2.0
subhiandrews
left a comment
There was a problem hiding this comment.
code-check review
No issues found.
Incomplete: no usable output from pragmatist; this review is not approved.
Reviewed with code-check · Apache-2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSDoc block above the
querygetter in lib/request.js says@return {String}, but the getter returns the parsed query object. This changes the tag to@return {Object}. I verified by reading the getter: it calls the configured query parser and returns its object result.Fixes #7525
AI-assisted; verified manually.