Repository navigation
docs: update outdated res.send() syntax in res.sendFile example (#7588) - #7598
Closed
VaibhavBajpaij wants to merge 1 commit into
Closed
VaibhavBajpaij wants to merge 1 commit into
VaibhavBajpaij wants to merge 1 commit into
Conversation
…essjs#7588) In lib/response.js, the JSDoc example for res.sendFile() still used the deprecated res.send(status, body) signature from Express 4.x, which was removed in Express 5. Update to the supported res.status(status).send(body) syntax. Fixes expressjs#7588 Signed-off-by: Vaibhav Bajpai <bajpaivaibhav2005@gmail.com>
Contributor
|
Duplicate of #7534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In \lib/response.js, the documentation comment for
es.sendFile()\ used
es.send(403, 'Sorry! you can't see that.');.
This signature
es.send(status, body)\ was deprecated in Express 4.x and removed in Express 5.0.
This PR updates the example to use the supported syntax:
\\js
res.status(403).send('Sorry! you can't see that.');
\\
Fixes #7588