chore(snap): fix staged content, stage -> build packages#1839
Open
kubiko wants to merge 1 commit into
Open
Conversation
`stage-packages` defines dependencies which are bundled in the snap and required @runtime `build-packages` defines build time dependencies - cmake: build time dependency - libz is already in core24 base snap -> libz-dev is build time dependency Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the wrong use of
stage-packagesvsbuild-packagesstage-packagesdefines dependencies, which are bundled in the snap and required @runtimebuild-packagesdefines build-time dependenciesCloser look at listed dependencies:
cmake: clear build-time dependencylibzis already incore24base snap ->libz-devis a build-time dependencyThis change will drastically reduce the size of the produced snap package
~36MB -> <1MB (amd64 target)