fix(options): keep COLUMNS from enabling icons auto#1843
Open
xfocus3 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COLUMNSand--widthas width inputs, so wide piped output can still use grid layout while--icons=autosuppresses icons when stdout is not a terminal.COLUMNSwith--icons=auto.git2to 0.21 and adjust branch-name handling for the current API, clearing the security advisories reported for 0.20.x.Fixes #1842.
Tests
cargo fmt --checkcargo test deduce_view_does_not_treat_columns_as_tty --libcargo test --libcargo testenv COLUMNS=200 cargo run -- --icons=auto <one-file-directory> | od -An -tx1 -cemittedfile\n