Skip to content

fix(options): keep COLUMNS from enabling icons auto#1843

Open
xfocus3 wants to merge 4 commits into
eza-community:mainfrom
xfocus3:fix/icons-auto-piped-columns
Open

fix(options): keep COLUMNS from enabling icons auto#1843
xfocus3 wants to merge 4 commits into
eza-community:mainfrom
xfocus3:fix/icons-auto-piped-columns

Conversation

@xfocus3

@xfocus3 xfocus3 commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • Use the actual stdout terminal state for automatic output behavior instead of deriving it from the configured terminal width.
  • Keep COLUMNS and --width as width inputs, so wide piped output can still use grid layout while --icons=auto suppresses icons when stdout is not a terminal.
  • Add regression coverage for COLUMNS with --icons=auto.
  • Update git2 to 0.21 and adjust branch-name handling for the current API, clearing the security advisories reported for 0.20.x.

Fixes #1842.

Tests

  • cargo fmt --check
  • cargo test deduce_view_does_not_treat_columns_as_tty --lib
  • cargo test --lib
  • cargo test
  • env COLUMNS=200 cargo run -- --icons=auto <one-file-directory> | od -An -tx1 -c emitted file\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: --icons=auto shows icons in non-TTY output when COLUMNS is set

1 participant