fix: sort newest aliases newest first#1853
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sort=newand--sort=newestto the existing newest-first modified-time ordering.--sort=oldand--sort=oldestto the existing oldest-first modified-time ordering.Fixes #1772
Tests
cargo fmt --all -- --checkcargo test deduce_sort_field_new --lib(failed before the fix, passed after the fix via focused alias tests)cargo test deduce_sort_field_ --libcargo test options::filter::tests --libcargo test --test cli_tests cli_all_testscargo test --test cli_tests cli_unix_testscargo test --libcargo check --all-targets--sort=newestproducednewest,middle,oldest;--sort=oldestproducedoldest,middle,newest.