fix(theme): ignore builtin LS_COLORS indicators#1856
Open
ychampion wants to merge 1 commit into
Open
Conversation
Builtin LS_COLORS keys describe file types and control codes. When eza does not implement one of those keys, it should not fall through to filename glob parsing. Fixes: eza-community#1682
ychampion
force-pushed
the
fix-ls-colors-indicators
branch
from
July 14, 2026 21:14
7d18e34 to
2a3ab55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1682.
LS_COLORSbuiltin keys such assu,sg,ca, andtware dircolors file-type/control indicators, not filename globs. When eza does not implement one of those indicators, it now ignores it instead of adding a matching filename pattern.EZA_COLORSkeeps the existing behavior for eza-only keys such assu.How Has This Been Tested?
env -u EZA_COLORS -u EXA_COLORS LS_COLORS='su=31' cargo run --quiet -- --color=always -1 /tmp/eza-lscolors-regression | od -An -tx1c->73 75 0acargo test --lib theme::customs_test -- --nocapturecargo testcargo clippy --lib -- -D warningscargo fmt --all -- --check