fix: require equals for icons values#1865
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
|
Hey! Just wanted to chime in, --icons isn't the only argument with this bug. --hyperlink was my introduction to it, and after running through the man page and checking options, here's the full list: Note: --code works, but breaks completion, (at least in fish) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require
--iconsoptional values to use=(for example--icons=always) so a bare--iconsdoes not consume the following positional file argument. Updated the parser/unit tests and powertest expectations for the help text and explicit icon modes.Fixes #1864
How Has This Been Tested?
cargo fmt --checkcargo test./target/debug/eza --icons src/options/parser.rs./target/debug/eza --icons=always src/options/parser.rs