fix(options): restore color compatibility aliases#1866
Open
ychampion wants to merge 1 commit into
Open
Conversation
Restore the hidden value and option aliases lost during the clap migration while keeping canonical names in help output. Fixes: eza-community#1863 Constraint: Preserve command lines accepted before v0.23.5 without changing canonical help output. Rejected: Add visible aliases to help | Legacy spellings should remain compatibility-only. Confidence: high Scope-risk: narrow Directive: Keep these aliases hidden unless the public CLI documentation intentionally changes. Tested: cargo test; cargo clippy --all-targets -- -D warnings; cargo fmt --all -- --check; parser regressions; CLI smoke tests. Not-tested: nix flake check (Nix is unavailable in this environment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The clap migration stopped accepting
--color=automaticeven thoughShowWhen::from_strstill maps it toauto. It also dropped the existing--colour-scaleand--colour-scale-modespellings.Restore those as hidden clap aliases, so existing command lines continue to work while help shows only the canonical values and options.
Fixes #1863
How Has This Been Tested?
cargo testcargo clippy --all-targets -- -D warningscargo fmt --all -- --checktarget/debug/eza --color=automatic --oneline Cargo.tomltarget/debug/eza --colour-scale=size --colour-scale-mode=fixed --long Cargo.toml