Skip to content

Accept zero-output as a valid seize in the recovery-disabled resample-merge test #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 1 commit into from
Jul 8, 2026
Merged

Accept zero-output as a valid seize in the recovery-disabled resample-merge test #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/integration/ezmsg/test_resample_merge_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def test_resample_merge_seizes_when_recovery_disabled_system(test_name: str | No
large sustained backward offset jump pushes the reference permanently below the
resampler's high-water mark and the merged output ceases well before input is exhausted.
"""
n_msgs, _, _, last_t = _run_resample_merge(
_, _, _, last_t = _run_resample_merge(
glitch_at=15,
glitch_back=100.0,
reset_after=float("inf"),
Expand All @@ -228,8 +228,12 @@ def test_resample_merge_seizes_when_recovery_disabled_system(test_name: str | No
# Output ceases at the chunk-15 glitch, so the last emitted sample sits near
# 15*30/1000 = 0.45 s; a recovered/healthy run reaches >= 0.799 s. Assert on
# last sample time (see _run) -- it isolates "output stopped early" from the
# variable amount of data dropped. n_msgs > 0 is a liveness sanity.
assert n_msgs > 0 and last_t < 0.6, f"Expected output to cease near the chunk-15 glitch, got {last_t:.3f} s."
# variable amount of data dropped. Zero output (last_t == -inf) also
# satisfies the property under test: on a loaded runner the pipeline's
# warmup can lose the race with the seize, so the graph ceases before its
# *first* emission. Liveness of the wiring itself is covered by
# test_resample_merge_healthy_system on the identical graph.
assert last_t < 0.6, f"Expected output to cease near the chunk-15 glitch, got {last_t:.3f} s."


def test_resample_merge_recovers_with_output_reference_system(test_name: str | None = None):
Expand Down
Loading