docs: straighten curly apostrophes in Popover and Banner best practices - #5772
Merged
Conversation
Replace the curly apostrophe in "task's" with a straight apostrophe in the Popover best-practice string across docs, docsZh, and docsDense. Prose-only, meaning unchanged.
Replace the \u2019 escape in "banner's" with a straight apostrophe in the Banner best-practice string. Prose-only, meaning unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsBanner (@astryxdesign/core) · View in Storybook
Popover (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # packages/core/src/Popover/Popover.doc.mjs
Matches the changelog standard applied to the other doc-prose PRs: copy that ships to builders through the published core docs gets a release line. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two AI-slop typographic tells (check 17, sub A4): curly apostrophes in component doc prose, straightened to ASCII
'. Prose strings only; meaning unchanged.packages/core/src/Popover/Popover.doc.mjs: the presentation best-practice string usedtask’s(curly apostrophe) indocs,docsZh, anddocsDense. Nowtask's.packages/core/src/Banner/Banner.doc.mjs: the collapsible best-practice string used a\u2019escape forbanner’s. The escape decodes to a curly apostrophe at render time, so it reaches CLI/Storybook output the same as a raw curly char. Now a straight'.Both were verified in the rendered CLI output (
astryx component Popover|Banner --lang dense): zero curly apostrophes,task'srenders correctly.Checklist
pnpm --filter @astryxdesign/core typecheck:docspassesNight Watch — Doc Reviewer