Skip to content

refactor(Popover): refine internal toggle API - #5793

Draft
imdreamrunner wants to merge 1 commit into
mainfrom
fix/refine-popover-toggle-options
Draft

refactor(Popover): refine internal toggle API#5793
imdreamrunner wants to merge 1 commit into
mainfrom
fix/refine-popover-toggle-options

Conversation

@imdreamrunner

Copy link
Copy Markdown
Contributor

Summary

  • refine the package-internal toggle signature to accept open/focus options
  • remove the duplicate toggleWithOptions method
  • preserve the public UsePopoverReturn.toggle contract as () => void

Follow-up to #5373.

Test plan

  • pnpm exec vitest run packages/core/src/Popover/Popover.test.tsx (40 tests)
  • pnpm -F @astryxdesign/core typecheck
  • pnpm lint:strict
  • pnpm build
  • core/lab/charts docs typechecks
  • CLI strict and template-docs typechecks
  • Storybook typecheck and build
  • pnpm lab:readiness:check
  • The full pnpm test run hit 12 unrelated CLI timeout flakes under concurrent load; rerunning those 12 files in isolation passed 100/100 tests.

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 5:59pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 31, 2026
github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox were not published for this CI run.

Modified Components

Popover (@astryxdesign/core)
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 798 -
Complexity N/A Very High (90) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

112 added · 0 removed. View the report

To accept these exact frames: /accept-visual 33422174176/1 <reason>

Added — After
Added — After visual regression frame

Added — After
Added — After visual regression frame

Added — After
Added — After visual regression frame


Generated by PR Enrichment workflow | View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant