docs(PowerSearch): define readable popover placement - #5804
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
marked this pull request as draft
September 1, 2026 04:15
cixzhang
force-pushed
the
docs/powersearch-popover-contract
branch
from
September 1, 2026 04:26
6f589d6 to
f16c16b
Compare
cixzhang
force-pushed
the
docs/powersearch-popover-contract
branch
from
September 1, 2026 13:49
f16c16b to
4784728
Compare
cixzhang
marked this pull request as ready for review
September 1, 2026 14:06
Contributor
Author
|
/approve-spec 4784728 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PowerSearch editor popovers currently stretch to the outer search width, which makes the small field/operator/value task harder to scan on wide filter bars. The editor also needs to stay near the exact control that opened it without adding callsite positioning API.
What
Records the accepted, current PowerSearch contract:
menuWidthremains the exact pixel width for the main field menu onlyThe contract depends on the current
component:Tokenizer/DEC-1authority landed by #5810 for the package-internal stable opening-control descriptor and safe fallback semantics.Status
The contract is accepted and current (
approved_by: cixzhang,approved_at: 2026-08-31), but this is not shipped behavior. Implementation remains pending, including real-Chromium story evidence for the 400/720 boundaries, start/end/tie controls, pointer and keyboard activation, LTR/RTL, narrow-viewport collision, opposite-side reopen, and no first-frame flash.Risk
Documentation only. No runtime or public API changes. No Changeset.
Testing
pnpm check:knowledgepnpm check:repopnpm exec prettier --check packages/core/src/PowerSearch/PowerSearch.spec.mdpnpm exec vitest run packages/core/src/PowerSearch/PowerSearch.test.tsx packages/core/src/PowerSearch/PowerSearchEditPopover.test.tsx packages/core/src/Tokenizer/Tokenizer.test.tsx packages/core/src/Typeahead/Typeahead.test.tsx(170 tests)