docs(spec): propose scoped Drawer contract - #5807
Draft
imdreamrunner wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Drawer is planned for Core, but #5550 exposes unresolved public decisions before promotion: whether an inspector belongs to the viewport or one region, whether regional blocking can honestly be called modal, whether modality and scrim are separate caller concepts, and how stacked Drawers behave across scopes.
What
spec:AST-007for Drawer scope, modality, scrim presentation, regional geometry, lifecycle, stacking, dismissal, and accessibility.containerRefas an explicit caller-owned regional target, with viewport scope on omission and a stable presented lifetime.aria-modalor body-lock claims.hasStackRecede, and theming variables to a separate design/theming decision.Relationship to #5550 and #5652
#5550 and #5652 remain implementation and presentation candidates. They establish feasibility and expose failure cases, but do not make this draft contract authoritative. The implementation must align with an accepted version of AST-007 before Core promotion.
AST-008 is already claimed by #5800; AST-007 is the lowest unclaimed system-spec ID on
mainand across open PRs.Risk
Knowledge only. No Lab/Core runtime, public package, generated artifact, visual output, or consumer behavior changes. The record remains
draft/proposed; no Drawer API is accepted until the open questions are resolved and the exact head receives owner approval. No Changeset.Validation
pnpm check:knowledge -- --base origin/mainpnpm check:repoarchitecture:layer-runtime,family:overlay-dismissal, feat(Drawer): independent scope, modality, and scrim paint #5550, and feat(Drawer): recede a buried drawer so a stack reads as layered pages #5652Review questions
containerRefbe the explicit regional target, stable through each presented lifetime?modalityandhasScrimremain independent, including a visible modal scrim as the outside-pointer dismissal plane?modaleven though it is not document modality,aria-modal,showModal(), or body scroll locking?