Skip to content

fix(knowledge): reject nested theme doc candidates - #5808

Draft
cixzhang wants to merge 1 commit into
mainfrom
fix/nested-theme-doc-candidates
Draft

fix(knowledge): reject nested theme doc candidates#5808
cixzhang wants to merge 1 commit into
mainfrom
fix/nested-theme-doc-candidates

Conversation

@cixzhang

@cixzhang cixzhang commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reject every Markdown candidate under docs/themes except the regular root README.md
  • keep recursive discovery bounded and avoid following symlink directories, roots, or file targets
  • classify nested theme-doc candidates as unsafe knowledge and cover the checker, change scope, and owner gate

Focused follow-up to #5792.

Test plan

  • pnpm exec vitest run --project node scripts/check-knowledge.test.mjs .github/scripts/change-scope.test.mjs .github/scripts/spec-owner-reconcile.test.mjs .github/scripts/spec-owner-workflow.test.mjs
  • pnpm check:knowledge --base origin/main
  • pnpm check:repo

No Changeset: this changes repository validation only.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 1, 2026
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 1, 2026 3:14am UTC

Request Review

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox were not published for this CI run.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant