Skip to content

feat(knowledge): reserve system spec IDs - #5809

Draft
cixzhang wants to merge 1 commit into
mainfrom
feat/spec-id-reservations
Draft

feat(knowledge): reserve system spec IDs#5809
cixzhang wants to merge 1 commit into
mainfrom
feat/spec-id-reservations

Conversation

@cixzhang

@cixzhang cixzhang commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Why

Concurrent system-spec proposals can choose the same AST-NNN ID before either pull request lands.

What

Adds a read-only allocator that considers landed specs and complete open-PR file inventories, a trusted exact-head collision check, and local path/frontmatter validation.

Risk

No package runtime behavior changes. GitHub availability is required only for allocation and the remote collision gate; normal check:knowledge stays offline.

Testing

  • pnpm exec vitest run --project node scripts/lib/spec-id.test.mjs .github/scripts/spec-id-collision.test.mjs scripts/check-knowledge.test.mjs
  • pnpm spec:id
  • pnpm check:repo
  • actionlint .github/workflows/spec-id-reservation.yml
  • pnpm exec prettier --check on changed files

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 1, 2026 3:22am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 1, 2026
github-actions Bot added a commit that referenced this pull request Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox were not published for this CI run.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant