fix(ci): prevent no-op review signal cancellations - #5812
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report
No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | View full report |
There was a problem hiding this comment.
Semantic verdict: request changes
An approved PR can still end with review-required: pending: flagging may snapshot reviews before an approval, Review clear then writes success, and the older flag run can overwrite it with pending on the same head. Because this status is required, maintainers are left with an approved but unmergeable PR and no later event guaranteed to repair it.
Please make approval the final projected state for this same-head interleaving, and add a focused test that pauses flagging after its review snapshot, lets Review clear succeed, then proves the final status remains success.
[Reviewed by Robohands]
Why
A head update followed by a draft/ready lifecycle transition can enqueue two Review signal runs for the same commit. Workflow-level cancellation makes the useful run appear cancelled/red even though the later duplicate succeeds.
What
Risk
Opened, synchronized, reopened, review-approval, and manual recovery paths remain covered. The workflow still never checks out or executes PR-controlled code.
Testing
pnpm check:repoNo Changeset: workflow-only infrastructure change.