Repository navigation
fix: add opt-in appendAutoPrefix for directory auto prefixes #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jean-michelet
merged 6 commits into
fastify:main
from
SergioChan:fix-issue-205-append-auto-prefix
Jul 24, 2026
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4664093
fix: add opt-in appendAutoPrefix for directory prefixes
SergioChan c5cf899
docs: clarify appendAutoPrefix behavior with route examples
SergioChan cabe227
Merge branch 'main' into fix-issue-205-append-auto-prefix
Tony133 4dba83c
test: simplify appendAutoPrefix cases
SergioChan 0653c09
test: use test cleanup hooks
SergioChan 5a73273
Merge branch 'main' into fix-issue-205-append-auto-prefix
Tony133 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| 'use strict' | ||
|
|
||
| module.exports = async function (app) { | ||
| app.get('/entity', async () => ({ ok: true })) | ||
| } | ||
|
|
||
| module.exports.autoPrefix = '/batch' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| 'use strict' | ||
|
|
||
| const { after, before, describe, it } = require('node:test') | ||
| const assert = require('node:assert') | ||
| const path = require('node:path') | ||
| const Fastify = require('fastify') | ||
| const autoLoad = require('../../../') | ||
|
|
||
| describe('Issue 205: append autoPrefix to directory prefixes without breaking defaults', function () { | ||
| describe('default behavior', function () { | ||
|
SergioChan marked this conversation as resolved.
Outdated
|
||
| const app = Fastify() | ||
|
|
||
| before(async function () { | ||
| app.register(autoLoad, { | ||
| dir: path.join(__dirname, 'routes'), | ||
| options: { prefix: '/hooked-plugin' } | ||
| }) | ||
| await app.ready() | ||
| }) | ||
|
|
||
| after(async function () { | ||
| await app.close() | ||
| }) | ||
|
|
||
| it('keeps autoPrefix overriding directory prefixes by default', async function () { | ||
| const overridden = await app.inject({ method: 'GET', url: '/hooked-plugin/batch/entity' }) | ||
| assert.strictEqual(overridden.statusCode, 200) | ||
| assert.deepStrictEqual(overridden.json(), { ok: true }) | ||
|
|
||
| const appended = await app.inject({ method: 'GET', url: '/hooked-plugin/children/batch/entity' }) | ||
| assert.strictEqual(appended.statusCode, 404) | ||
| }) | ||
| }) | ||
|
|
||
| describe('appendAutoPrefix: true', function () { | ||
| const app = Fastify() | ||
|
|
||
| before(async function () { | ||
| app.register(autoLoad, { | ||
| dir: path.join(__dirname, 'routes'), | ||
| options: { prefix: '/hooked-plugin' }, | ||
| appendAutoPrefix: true | ||
| }) | ||
| await app.ready() | ||
| }) | ||
|
|
||
| after(async function () { | ||
| await app.close() | ||
| }) | ||
|
|
||
| it('concatenates directory prefixes before plugin autoPrefix', async function () { | ||
| const appended = await app.inject({ method: 'GET', url: '/hooked-plugin/children/batch/entity' }) | ||
| assert.strictEqual(appended.statusCode, 200) | ||
| assert.deepStrictEqual(appended.json(), { ok: true }) | ||
|
|
||
| const overridden = await app.inject({ method: 'GET', url: '/hooked-plugin/batch/entity' }) | ||
| assert.strictEqual(overridden.statusCode, 404) | ||
| }) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.