Repository navigation
fix: try every encoding in a root before falling back to the next root - #629
Merged
Tony133 merged 2 commits intoNov 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
preCompressed: trueand an arrayroot, a file that exists only in the first root without a pre-compressed variant returns 404 when the request sendsAccept-Encoding.On
ENOENT, the handler moved to the next root before it tried the remaining encodings in the current root, so the encoding fallback, including the uncompressed file, ran only in the last root.This change tries the remaining encodings and then the uncompressed file in the current root before it moves to the next root. An earlier root still wins over a later one, which matches the behavior without
preCompressed. It also drops the extra identity lookup that the previouscheckedEncodings.has(undefined)check caused.Fixes #628
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct