Skip to content

Always warm start for ACL-only VLAN configuration change - #4819

Open
gizmoguy wants to merge 1 commit into
faucetsdn:mainfrom
gizmoguy:warm-vlan-acl
Open

Always warm start for ACL-only VLAN configuration change#4819
gizmoguy wants to merge 1 commit into
faucetsdn:mainfrom
gizmoguy:warm-vlan-acl

Conversation

@gizmoguy

Copy link
Copy Markdown
Member

When detecting config changes on SIGHUP, treat VLANs with an ACL-only change the same as ports with an ACL-only change and warm start.

supersedes #4733

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.49%. Comparing base (076889d) to head (a5e2454).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
+ Coverage   91.42%   91.49%   +0.07%     
==========================================
  Files          46       46              
  Lines        8923     8938      +15     
==========================================
+ Hits         8157     8177      +20     
+ Misses        766      761       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gizmoguy
gizmoguy marked this pull request as draft June 24, 2026 02:37
@gizmoguy
gizmoguy marked this pull request as ready for review June 24, 2026 03:55
@gizmoguy
gizmoguy force-pushed the warm-vlan-acl branch 2 times, most recently from 36f7128 to fc4eb53 Compare June 25, 2026 23:30
Co-authored-by: hieunt79 <nguyenhieu26496@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant