Skip to content

Validate WebSocket handshake keys #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
Closed

Validate WebSocket handshake keys #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/websocket/driver/hybi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,16 @@ def handshake_response
raise ProtocolError.new('Missing handshake request header: Sec-WebSocket-Key')
end

begin
valid_key = Base64.strict_decode64(sec_key).bytesize == 16
rescue ArgumentError
valid_key = false
end

unless valid_key
raise ProtocolError.new('Invalid handshake request header: Sec-WebSocket-Key')
end

@headers['Upgrade'] = 'websocket'
@headers['Connection'] = 'Upgrade'
@headers['Sec-WebSocket-Accept'] = Hybi.generate_accept(sec_key)
Expand Down