Skip to content

Reject repeated activation of the same extension session #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 2 commits into from
Closed

Reject repeated activation of the same extension session #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580838d
Reject repeated activation of the same extension session
OskarEichler Aug 28, 2026
3a743d0
Add extension lifecycle regression coverage
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/websocket/extensions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def generate_offer
def activate(header)
responses = Parser.parse_header(header)
@sessions = []
activated = {}

responses.each_offer do |name, params|
unless record = @index[name]
Expand All @@ -83,6 +84,11 @@ def activate(header)

ext, session = *record

if activated[name]
raise ExtensionError, %Q{Server sent multiple responses for extension "#{ name }"}
end
activated[name] = true

if reserved = reserved?(ext)
raise ExtensionError, %Q{Server sent two extension responses that use the RSV#{ reserved[0] }} +
%Q{bit: "#{ reserved[1] }" and "#{ ext.name }"}
Expand Down
7 changes: 7 additions & 0 deletions spec/websocket/extensions_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@
expect { @extensions.activate("tar") }.not_to raise_error
end

it "rejects duplicate responses for an extension without reserved bits" do
allow(@ext).to receive(:rsv1).and_return(false)
expect(@session).to receive(:activate).with({}).exactly(1).and_return(true)

expect { @extensions.activate("deflate, deflate") }.to raise_error(ExtensionError)
end

it "raises if two extensions conflict on RSV bits" do
expect { @extensions.activate("deflate, tar") }.to raise_error(ExtensionError)
end
Expand Down