Skip to content

See if we can bump C++ to 23 on targeting CI - #1623

Merged
wengxt merged 1 commit into
masterfrom
23
Aug 25, 2026
Merged

See if we can bump C++ to 23 on targeting CI#1623
wengxt merged 1 commit into
masterfrom
23

Conversation

@wengxt

@wengxt wengxt commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Enhancements
    • Updated the project to use the C++23 language standard for improved compatibility with modern C++ features.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f3f8a7d2-30cd-4eb8-a76e-d2074a174e1f

📥 Commits

Reviewing files that changed from the base of the PR and between 6f8f9fa and ff10868.

📒 Files selected for processing (1)
  • cmake/Fcitx5CompilerSettings.cmake
🚧 Files skipped from review as they are similar to previous changes (1)
  • cmake/Fcitx5CompilerSettings.cmake

📝 Walkthrough

Walkthrough

The project-wide C++ standard is updated from C++20 to C++23 in the shared CMake compiler settings.

Changes

C++23 compiler standard

Layer / File(s) Summary
Update project compiler standard
cmake/Fcitx5CompilerSettings.cmake
CMAKE_CXX_STANDARD changes from 20 to 23.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: evaluating an upgrade to C++23 for CI targeting.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot mentioned this pull request Aug 3, 2026
@wengxt
wengxt merged commit 7e0b09d into master Aug 25, 2026
6 checks passed
@wengxt
wengxt deleted the 23 branch August 25, 2026 22:48
wengxt added a commit that referenced this pull request Aug 26, 2026
This reverts commit 7e0b09d.

libc++ on windows doesn't have much support on the feature we need, not
much point to upgrade right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant