Repository navigation
fix(dash0): stop pre-filling a webmail domain as the first check target - #532
Merged
Merged
Conversation
The zero-check dashboard pre-fills the signup's email domain as the URL to monitor, skipping free webmail. The skip list only had .com names, so a @gmx.de, @yahoo.fr or @orange.fr signup was offered its mail provider as its first check. Country variants of the big providers (gmx.de, yahoo.co.uk, hotmail.fr, mail.ru) are now matched by brand, and national providers (web.de, t-online.de, orange.fr, free.fr, laposte.net...) are listed. The same rule backs the auto-join pattern check, so an admin can no longer claim @gmx\.de and auto-admit every signup from that provider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 82.71% 82.76% +0.04%
==========================================
Files 1175 1175
Lines 121451 121460 +9
==========================================
+ Hits 100463 100525 +62
+ Misses 20981 20928 -53
Partials 7 7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three defects on the signup path, found by reading PostHog replays of real signups that ended with zero checks.
1. Fixed: the first check target was the user's mail provider
The zero-check dashboard pre-fills the signup's email domain as the URL to monitor, and skips free webmail. The skip list only held
.comnames. A recent@gmx.designup gotgmx.depre-filled, never typed anything, and left without a check. Same for@yahoo.fr,@hotmail.co.uk,@web.de,@orange.frand so on.gmx.de,gmx.net,yahoo.co.uk,hotmail.fr,mail.ru. A brand label deeper in the name is not (mail.acme.comis still suggested).web.de,t-online.de,orange.fr,free.fr,laposte.net,libero.it,btinternet.com,uol.com.br...validateAutoJoinRegex, so an admin can no longer set.+@gmx\.deand auto-admit every signup from that provider. Nothing sets that pattern automatically, so this was defense in depth only.Files:
server/internal/handlers/auth/autojoin_regex.go(source of truth) andweb/dash0/src/lib/quick-target-suggestion.ts(mirror), with tests on both sides.2. Spec: a first-time visitor is told their session expired
specs/todos/2026-10-12-01-first-visit-no-session-expired-banner.md. Openingsolidping.ioin a fresh browser lands on/d/orgs/default/login?session_expired=truewith "Your session has expired". Cause:RootRedirectsends a visitor with no session to/no-org, its requests 401, andhandleResponsealways callsredirectToExpiredLogin(), which always sets the flag.3. Already filed: signing up from the demo files a join request to
demoCovered by
specs/todos/2026-10-10-02-demo-org-no-membership-request.md, nothing added here.Checks
go test -short ./internal/handlers/auth/passesgolangci-lint run ./...: 0 issuesvitest run src/lib/quick-target-suggestion.test.ts: 51 passed🤖 Generated with Claude Code