[fclairamb]

Problem

The checks list said "12 status-page incidents are open on Live demo status while every linked check is up". Clicking "Review it" opened the status page, which has nothing to review.

Two bugs:

1. Entries never closed. When a grouped check recovers, OnIncidentResolved kept its entry open if any other group member was down. A member had been down since 2026-09-07 with no entry of its own, so for six weeks no other member's entry could close. Deleting that member did not help either: the delete resolves the incident after the soft delete, GetCheck no longer found the check, and the group lookup came back empty.
2. Nothing to review. With more than one stale entry, the banner linked to the status page. dash0 has no list of a page's entries, so the link went nowhere useful.

Fix

• An entry now waits only for the members it covers: the incident it is attached to, or a member that failed after that incident and has no entry of its own on the page (what consolidation produces). If a lookup fails, the entry stays open.
• incidentGroupUID reads the check with GetCheckIncludingDeleted.
• The background incidents service (demo cleanup sweep, private-location monitor deletes) gets the publication hook. It has no subscriber notifier, because the egress guard is built later.
• With several stale entries, the banner lists each one with a link to its edit page.

Tests

• TestLongDownSiblingDoesNotHoldAnotherMembersEntryOpen
• TestDeletingTheLastMemberClosesTheConsolidatedEntry
• The existing tests for "closes only with the last member" and the hand-published group entry still pass.
• stale-publications-banner.test.tsx: one link when there is one entry, one link per entry when there are several.

go test -short ./..., golangci-lint, tsc and the vitest suites pass locally.

The 12 entries already open in prod will not close on their own after deploy, because their resolve already ran. They need to be closed once by hand.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (b84af78) to head (befdb9b).

Files with missing lines	Patch %	Lines
...er/internal/handlers/incidentpublications/group.go	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   83.32%   83.37%   +0.05%     
==========================================
  Files        1238     1238              
  Lines      127041   127064      +23     
==========================================
+ Hits       105854   105945      +91     
+ Misses      21178    21110      -68     
  Partials        9        9              

Files with missing lines	Coverage Δ
server/internal/app/server.go	81.79% <100.00%> (+0.02%)	⬆️
...r/internal/handlers/incidentpublications/policy.go	77.33% <100.00%> (+0.22%)	⬆️
...er/internal/handlers/incidentpublications/group.go	82.60% <90.00%> (+3.22%)	⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fclairamb]

Added TestSiblingWithItsOwnEntryDoesNotHoldTheGroupEntryOpen, which covers the owner lookup and the "sibling has its own entry" branches of publicationCoversActiveSibling (90.9% of the function now; only the two DB-error branches are left).

🤖 Addressed by Claude Code