[DEV-14781] Fail Downloads during Pipeline - #4735
Open
DavidMikolaKC wants to merge 2 commits into
Open
Conversation
DavidMikolaKC
added
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There is current unhandled behavior that prevents download jobs from erroring out properly when executed while the pipeline is running. This end result for the user is a download job that never fully closing, continuing to be marked as "in progress" when it should be marked as "failed".
Technical Details:
A specific check for errors resulting from "recovery conflicts" (the types of errors resulting from the pipeline) has been added to the execute_psql() subprocess function in download_generatoin.py. This check explicitly calls the fail_download function to ensure the error process can continue as expected. The previous behavior had failed to climb the except tree to hit the intended handler for errors, so this should fix that.
Requirements for PR Merge: