Skip to content

Update CGAL version to v6.2.1 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JavierCladellas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CGAL version to v6.2.1 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d8113
Update CGAL version to v6.2.1
JavierCladellas Sep 10, 2026
72b4713
reapply and fix cgal patch concerning ccdt3
JavierCladellas Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmake/cgal.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h b/Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
index 49bb82f27..2c4d03529 100644
--- a/Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
+++ b/Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
@@ -1335,7 +1335,7 @@ protected:
const auto face_id = static_cast<std::size_t>(cell->ccdt_3_data().face_constraint_index(facet_index));
this->face_constraint_misses_subfaces_set(face_id);
auto fh_2 = cell->ccdt_3_data().face_2(this->face_cdt_2(face_id), facet_index);
- fh_2->info().facet_3d = {};
+ fh_2->info().facet_3d = decltype(fh_2->info().facet_3d){};
fh_2->info().missing_subface = true;
this->set_facet_constrained({cell, facet_index}, -1, {});
}
3 changes: 2 additions & 1 deletion cmake/importDependenciesHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ macro(importDependency_CGAL _useSystem _target_dependencies _target_definitions
find_package(CGAL REQUIRED COMPONENTS Core)
else()
FetchContent_Declare( cgal GIT_REPOSITORY https://github.com/CGAL/cgal.git
GIT_TAG v6.2
GIT_TAG v6.2.1
PATCH_COMMAND git apply "${FEELPP_CORE_CMAKE_DIR}/cgal.patch" UPDATE_DISCONNECTED 1
GIT_SHALLOW ON
)
set( WITH_CGAL_Qt5 OFF )
Expand Down
Loading