Icon - #344
Open
Hitha245 wants to merge 2 commits into
Open
Conversation
Refactored GetForUser test to include service initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR adds backend support for optional emoji icons on Goals, so the icon selected on the client can be persisted to MongoDB and returned by the API.
Models/Goal.cs: Added an optionalIconfield (string?) to theGoalmodel. It's a plain string (not anObjectId), so it needs no[BsonRepresentation]attribute — Mongo's driver serializes/deserializes it automatically. Existing seeded goals with no icon simply come back with"icon": null.CommBank.Tests/GoalControllerTests.cs: Filled in the previously-emptyGetForUsertest, following the same Arrange/Act/Assert pattern asGetAll/Get— asserts the result isn't null and that every returned goal is assignable fromGoalwith the expectedUserId.Why
The frontend now lets users pick an emoji for a goal (via
emoji-mart) and needs the server to accept and return that field so the icon persists across page refreshes. This closes the loop on the client → server → database round trip.Testing
POST/PUTon/api/Goalnow accepts aniconfield andGETreturns it.GetForUserroute.Notes for reviewers
No breaking changes —
Iconis optional and nullable, so existing clients/documents are unaffected.