feat(calm-hub): tag Docker images with project version - #2948
Conversation
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
|
@jpgough-ms do you have comments on this? |
rocketstack-matt
left a comment
There was a problem hiding this comment.
These version tags (0.7.6, 0.7.6-native, 0.7.6-read-only-static, 0.7.6-read-only-native) come from calm-hub/pom.xml, which isn't bumped automatically per commit/release. Docker Hub tags are mutable by default and this PR doesn't enable Immutable Tags on the repo, so every push to main between manual version bumps will silently overwrite the same tag with a different image build. That contradicts the PR description's claim of an "immutable release-oriented tag." Is the version bump expected to happen in lockstep with these publishes, or should Immutable Tags be enabled on the Docker Hub repo to actually guarantee that?
|
Good catch — you're right. With the current I propose publishing the semantic tags only from an explicit CALM Hub release ref, validating that the ref version matches |
|
@jpgough-ms thoughts on version convention? |
Description
Closes #2833.
Adds semantic version tags derived from
calm-hub/pom.xmlto all four CALM Hub Docker publication variants:0.7.60.7.6-read-only-static0.7.6-native0.7.6-read-only-nativeThe existing latest/custom, SHA, branch, and Git tag aliases remain unchanged. This gives consumers an immutable release-oriented tag without removing the current publication conventions.
Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
The commit follows the repository's Conventional Commits format and includes a DCO sign-off.
Testing
Local validation:
calm-hub/pom.xmlversion (0.7.6) as semantic numeric version data;git diff --check.The Docker publishing jobs require repository credentials and are therefore left to GitHub Actions.
Checklist