Feat/issue 2953 layout parity between calm hub and code plugin - #2987
Conversation
|
|
f19edbf to
3350c9b
Compare
|
Addresses #2953 This supports both in Document & Layout in Calm Hub. |
|
@markscott-ms @jpgough-ms Please let us know what you think. Thank You. |
rocketstack-matt
left a comment
There was a problem hiding this comment.
Two blocking issues below (unsaved-edit data loss, missed container type in the reflow-skip check), plus two non-blocking design/scope notes.
Separately: issue #2953 is still open with an unresolved objection from @markscott-ms about persisting layout inside the architecture document at all, and no explicit design sign-off — worth settling there before this merges, independent of the code-level points below.
Hello @rocketstack-matt , Appreciate your feedback. All the mentioned issues has now been resolved and change should be in PR soon. Regarding layout, Our priority is to have uniform rendering of CALM Diagrams in all tools in CALM suite being it VS Code or Calm Hub or Calm docify rendered markdown files. As you are aware we have choose Git as the backend store which acts as the single source of truth for all the tools in CALM suite and works consistently. Hence having layout as part of calm file itself was a design decision chosen so that it renders in VS Code plugin, reading layout form calm file itself. We are happy for it to be external as long as its works consistent across all the tools. Until we have a solution that works meeting those needs, we have added this as a tactical solution to be able to support the ask. @markscott-ms Can we add it as an item for our next WG item to discuss and brainstorm further on this matter, if required. Many Thanks! FYI: @jimthompson5802 |
|
@byrash just flagging the failing build - happy to take another look once resolved. |
Build is all good now. Thanks! |
rocketstack-matt
left a comment
There was a problem hiding this comment.
Both blocking items and both non-blocking items from my prior review are resolved and tested.
|
Hello @markscott-ms can we please merge this PR ? Many Thanks! |
Description
Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist