Skip to content

Feat/issue 2953 layout parity between calm hub and code plugin - #2987

Open
byrash wants to merge 8 commits into
finos:mainfrom
fidelity-contributions:feat/issue-2953-Layout-Parity-Between-Calm-Hub-and-Code-Plugin
Open

Feat/issue 2953 layout parity between calm hub and code plugin#2987
byrash wants to merge 8 commits into
finos:mainfrom
fidelity-contributions:feat/issue-2953-Layout-Parity-Between-Calm-Hub-and-Code-Plugin

Conversation

@byrash

@byrash byrash commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Code style/formatting changes
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvements
  • ✅ Test additions or updates
  • 🔧 Chore (maintenance, dependencies, CI, etc.)

Affected Components

  • CLI (cli/)
  • Schema (calm/)
  • CALM AI (calm-ai/)
  • CALM Hub (calm-hub/)
  • CALM Hub UI (calm-hub-ui/)
  • CALM Server (calm-server/)
  • CALM Widgets (calm-widgets/)
  • Documentation (docs/)
  • Shared (shared/)
  • VS Code Extension (calm-plugins/vscode/)
  • Dependencies
  • CI/CD

Commit Message Format ✅

Testing

  • I have tested my changes locally
  • I have added/updated unit tests
  • All existing tests pass

Checklist

  • My commits follow the conventional commit format
  • I have updated documentation if necessary
  • I have added tests for my changes (if applicable)
  • My changes follow the project's coding standards

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 13, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: byrash / name: Shivaji Byrapaneni (3350c9b)

@github-actions github-actions Bot added calm-hub Affects `calm-hub` calm-hub-ui Affects `calm-hub-ui` labels Aug 13, 2026
@apurvagandhi
apurvagandhi force-pushed the feat/issue-2953-Layout-Parity-Between-Calm-Hub-and-Code-Plugin branch from f19edbf to 3350c9b Compare August 13, 2026 16:25
@byrash

byrash commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Addresses #2953

This supports both in Document & Layout in Calm Hub.

@byrash

byrash commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@markscott-ms @jpgough-ms Please let us know what you think. Thank You.

@rocketstack-matt rocketstack-matt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two blocking issues below (unsaved-edit data loss, missed container type in the reflow-skip check), plus two non-blocking design/scope notes.

Separately: issue #2953 is still open with an unresolved objection from @markscott-ms about persisting layout inside the architecture document at all, and no explicit design sign-off — worth settling there before this merges, independent of the code-level points below.

Comment thread calm-hub-ui/src/visualizer/components/reactflow/ArchitectureGraph.tsx Outdated
Comment thread calm-hub-ui/src/visualizer/services/node-position-service.tsx Outdated
Comment thread calm-hub/src/main/resources/application.properties Outdated
@byrash

byrash commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Two blocking issues below (unsaved-edit data loss, missed container type in the reflow-skip check), plus two non-blocking design/scope notes.

Separately: issue #2953 is still open with an unresolved objection from @markscott-ms about persisting layout inside the architecture document at all, and no explicit design sign-off — worth settling there before this merges, independent of the code-level points below.

Hello @rocketstack-matt , Appreciate your feedback. All the mentioned issues has now been resolved and change should be in PR soon.

Regarding layout, Our priority is to have uniform rendering of CALM Diagrams in all tools in CALM suite being it VS Code or Calm Hub or Calm docify rendered markdown files. As you are aware we have choose Git as the backend store which acts as the single source of truth for all the tools in CALM suite and works consistently. Hence having layout as part of calm file itself was a design decision chosen so that it renders in VS Code plugin, reading layout form calm file itself. We are happy for it to be external as long as its works consistent across all the tools. Until we have a solution that works meeting those needs, we have added this as a tactical solution to be able to support the ask.

@markscott-ms Can we add it as an item for our next WG item to discuss and brainstorm further on this matter, if required.

Many Thanks!

FYI: @jimthompson5802

@rocketstack-matt

Copy link
Copy Markdown
Member

@byrash just flagging the failing build - happy to take another look once resolved.

@byrash

byrash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@byrash just flagging the failing build - happy to take another look once resolved.

Build is all good now. Thanks!

@rocketstack-matt rocketstack-matt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both blocking items and both non-blocking items from my prior review are resolved and tested.

@byrash

byrash commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Hello @markscott-ms can we please merge this PR ? Many Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

calm-hub Affects `calm-hub` calm-hub-ui Affects `calm-hub-ui` config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants