fix: refactor Dockerfile to speed up run times#1521
Open
jescalada wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 69 69
Lines 5561 5561
Branches 958 958
=======================================
Hits 5019 5019
Misses 523 523
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Dockerfileslow runtimes (5-10 mins each) to speed up E2E test execution speeds.Note that Docker Compose step execution times may vary considerably depending on whether we've executed the CI "recently" (perhaps within a few hours). Another factor might be Docker/NPM traffic spikes that make fetching slow.
I've seen worst-case executions of around 15 mins:
Before
~7m without caching

~2m 10s when cached

After
~4m 50s without caching (~30% faster)

~1m 20s when cached (~35% faster)
