Skip to content

chore(deps): bump uuid to v10 across affected packages #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cabljac wants to merge 2 commits into
base: next
Choose a base branch
from
Open

chore(deps): bump uuid to v10 across affected packages #2815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b3c48
chore(deps): bump uuid to v10 across affected packages
cabljac May 8, 2026
b7e3890
chore(deps): retarget uuid bump to v11.1.0
cabljac May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions firestore-counter/clients/node/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion firestore-counter/clients/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"firebase-admin": "^13.0.0"
},
"dependencies": {
"uuid": "^8.3.2"
"uuid": "^10.0.0"
Comment thread
cabljac marked this conversation as resolved.
Outdated
}
}
26 changes: 16 additions & 10 deletions firestore-counter/clients/web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions firestore-counter/clients/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"license": "Apache-2.0",
"description": "Web SDK to access sharded counters.",
"dependencies": {
"@types/uuid": "^3.4.4",
"uuid": "^3.3.2"
"@types/uuid": "^10.0.0",
"uuid": "^10.0.0"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since uuid version 9 and above includes built-in TypeScript definitions, the @types/uuid package is redundant and can be removed. Additionally, as uuid version 11.1.0+ supports CommonJS and version 10 is now marked as unsupported, it is recommended to upgrade directly to ^11.1.0.

    "uuid": "^11.1.0"

},
"devDependencies": {
"firebase": "^12.0.0",
Expand Down
43 changes: 14 additions & 29 deletions firestore-counter/functions/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion firestore-counter/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"deep-equal": "^1.0.1",
"firebase-admin": "^12.1.0",
"firebase-functions": "^4.9.0",
"uuid": "^3.3.2",
"uuid": "^10.0.0",
Comment thread
cabljac marked this conversation as resolved.
Outdated
"rimraf": "^2.6.3",
"typescript": "^4.9.4",
"@types/express-serve-static-core": "4.19.8"
Expand Down
71 changes: 19 additions & 52 deletions storage-resize-images/functions/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions storage-resize-images/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"sharp": "^0.34.5",
"shx": "^0.4.0",
"typescript": "^5.7.3",
"uuid": "^11.0.5",
"uuidv4": "^6.1.0"
"uuid": "^10.0.0"
Comment thread
cabljac marked this conversation as resolved.
Outdated
},
"devDependencies": {
"@types/jest": "^29.5.14",
Expand Down
6 changes: 3 additions & 3 deletions storage-resize-images/functions/src/resize-image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as path from "path";
import * as fs from "fs";

import { Bucket } from "@google-cloud/storage";
import { uuid } from "uuidv4";
import { v4 as uuidv4 } from "uuid";

import { config } from "./config";
import * as logs from "./logs";
Expand Down Expand Up @@ -103,7 +103,7 @@ export const modifyImage = async ({
let modifiedFile: string;

try {
modifiedFile = path.join(os.tmpdir(), uuid());
modifiedFile = path.join(os.tmpdir(), uuidv4());

// filename\*=utf-8'' selects any string match the filename notation.
// [^;\s]+ searches any following string until either a space or semi-colon.
Expand Down Expand Up @@ -203,7 +203,7 @@ export const constructMetadata = (
config.regenerateToken &&
metadata.metadata.firebaseStorageDownloadTokens
) {
metadata.metadata.firebaseStorageDownloadTokens = uuid();
metadata.metadata.firebaseStorageDownloadTokens = uuidv4();
}
return metadata;
};
Expand Down
Loading