fix(firestore-bigquery-change-tracker): unmask BQ errors and stop spurious table updates

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/checkUpdates.ts

@@ -23,7 +23,7 @@ export async function tableRequiresUpdate({
   const { metadata } = table;
 
   /** Check clustering */
-  const configCluster = JSON.stringify(config.clustering);
+  const configCluster = JSON.stringify(config.clustering || []);
   const tableCluster = JSON.stringify(metadata.clustering?.fields || []);
   if (configCluster !== tableCluster) return true;
 

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/handleFailedTransactions.ts

@@ -7,15 +7,30 @@ if (!admin.apps.length) {
   initializeApp();
 }
 
+const settingsApplied = new Set<string>();
+
+const getConfiguredFirestore = (instanceId: string) => {
+  const db = getFirestore(instanceId);
+  if (!settingsApplied.has(instanceId)) {
+    settingsApplied.add(instanceId);
+    try {
+      db.settings({ ignoreUndefinedProperties: true });
+    } catch {
+      // Firestore.settings() throws if the singleton has already been used
+      // elsewhere in the process. The dead-letter path doesn't strictly
+      // depend on ignoreUndefinedProperties, so swallow rather than crash
+      // and mask the original BigQuery error that led us here.
+    }
+  }
+  return db;
+};
+
 export default async (
   rows: any[],
   config: ChangeTrackerConfig,
   e: Error
 ): Promise<void> => {
-  const db = getFirestore(config.firestoreInstanceId!);
-  db.settings({
-    ignoreUndefinedProperties: true,
-  });
+  const db = getConfiguredFirestore(config.firestoreInstanceId!);
   const batchArray = [db.batch()];
 
   let operationCounter = 0;

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts

@@ -341,14 +341,14 @@ export class FirestoreBigQueryEventHistoryTracker
 
       await clustering.updateClustering(metadata);
 
-      const documentIdColExists = fields.find(
+      const documentIdColExists = !!fields.find(
         (column) => column.name === "document_id"
       );
-      const pathParamsColExists = fields.find(
+      const pathParamsColExists = !!fields.find(
         (column) => column.name === "path_params"
       );
 
-      const oldDataColExists = fields.find(
+      const oldDataColExists = !!fields.find(
         (column) => column.name === "old_data"
       );