Fix Adjoint + Fieldsplit#5197
Merged
Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/fix/adjoint-fieldsplit
branch
from
2ba3cfd to
dd11052
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/adjoint-fieldsplit
branch
from
dd11052 to
4eb3456
Compare
connorjward
approved these changes
Jun 22, 2026
connorjward
left a comment
connorjward
left a comment
Contributor
There was a problem hiding this comment.
This looks fine but I am worried about the new ngsPETSc failures.
Contributor
Author
We're on it: NGSolve/ngsPETSc#120 I'm still trying to figure out the new API they changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5193