Filter OTEL by environment#47574
Conversation
|
@coderabbitai full review |
|
/agentic_review |
✅ Action performedFull review finished. |
Code Review by Qodo
1. Duplicate env resource attribute
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe Fleet OTEL provider ( 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tools/signoz/host_cache_dashboard.json (1)
46-46: 💤 Low valueIncidental improvement: hit rate target raised to 90%.
The hit rate description and threshold are updated from 80% to 90%. This is a sensible operational improvement but is not directly related to the environment filtering feature. Consider noting this change separately in the changelog or PR description for clarity.
Also applies to: 106-106
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/signoz/host_cache_dashboard.json` at line 46, The hit rate target has been updated from 80% to 90% in the host_cache_dashboard.json file at line 46 (and also at line 106). While this is a sensible operational improvement, it is not directly related to the main feature being implemented. Add a note to the changelog or PR description clearly documenting this as a separate, incidental improvement to the cache hit rate target. This will help clarify that the change is an independent operational update and not part of the core feature work.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tools/signoz/host_cache_dashboard.json`:
- Line 46: The hit rate target has been updated from 80% to 90% in the
host_cache_dashboard.json file at line 46 (and also at line 106). While this is
a sensible operational improvement, it is not directly related to the main
feature being implemented. Add a note to the changelog or PR description clearly
documenting this as a separate, incidental improvement to the cache hit rate
target. This will help clarify that the change is an independent operational
update and not part of the core feature work.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 65590ecb-154c-47bb-8543-eb8005a23856
⛔ Files ignored due to path filters (1)
tools/signoz/README.mdis excluded by!**/*.md
📒 Files selected for processing (5)
changes/47573-signoz-dashboards-deployment-environmentcmd/fleet/otel.gotools/signoz/database_custom_dashboard.jsontools/signoz/host_cache_dashboard.jsontools/signoz/http_errors_dashboard.json
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Updates Fleet’s OpenTelemetry resource attributes and bundled SigNoz dashboards so operators can filter metrics by deployment environment using a shared environment dashboard variable backed by the deployment.environment resource attribute.
Changes:
- Emit
deployment.environment(defaultdefault, overridable viaOTEL_RESOURCE_ATTRIBUTES) in Fleet OTEL resource attributes. - Add an
environmentdashboard variable +deployment.environment IN $environmentfiltering to the existing SigNoz dashboards. - Add a new pre-canned
http_errors_dashboard.jsonand document it intools/signoz/README.md.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/fleet/otel.go | Adds default environment resource attributes so SigNoz can dynamically discover and filter by environment. |
| tools/signoz/README.md | Documents the new HTTP errors dashboard and the cross-dashboard environment selector convention. |
| tools/signoz/http_errors_dashboard.json | New dashboard for fleet.http.client_errors / fleet.http.server_errors with environment filtering. |
| tools/signoz/host_cache_dashboard.json | Adds environment variable and filters queries by deployment.environment (also changes hit-rate target/threshold). |
| tools/signoz/database_custom_dashboard.json | Adds environment variable and filters all panels by deployment.environment. |
| changes/47573-signoz-dashboards-deployment-environment | User-visible change entry (content excluded by policy). |
Files excluded by content exclusion policy (1)
- changes/47573-signoz-dashboards-deployment-environment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47574 +/- ##
========================================
Coverage 67.19% 67.19%
========================================
Files 3489 3491 +2
Lines 228536 228717 +181
Branches 11872 11872
========================================
+ Hits 153557 153695 +138
- Misses 61154 61186 +32
- Partials 13825 13836 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Related issue: Resolves #47573
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Summary by CodeRabbit
New Features
Improvements