fix: force FBO recreation for Chromium/Electron windows after dock restore#164
Open
Mr-ZeLong wants to merge 1 commit into
Open
fix: force FBO recreation for Chromium/Electron windows after dock restore#164Mr-ZeLong wants to merge 1 commit into
Mr-ZeLong wants to merge 1 commit into
Conversation
…store When Chromium/Electron apps (QQ, WeChat, Chrome, Edge, Brave, etc.) are shown from the dock, Mutter's ClutterOffscreenEffect reuses the offscreen FBO populated during the unminimize animation. During that animation the FBO was populated at intermediate (scaled) resolutions with whatever stale Wayland buffer the client still holds, resulting in blurry window content that persists until the mouse enters. The fix forces FBO invalidation by toggling the GLSLEffect's enabled state (enabled=false destroys the offscreen, enabled=true allocates a fresh one on the next pre_paint). For Chromium windows this runs after a 250ms delay to let the Wayland renderer deliver a settled frame. Two trigger paths are covered: - onUnminimize: window was minimized and is restored from dock - onFocusChanged: window was behind others and is brought to front Also adds periodic shader refreshes for Chromium windows to nudge Mutter toward full-resolution buffer allocation on fractional-scaled displays.
Owner
|
@Mr-ZeLong did you read the pull request guidelines? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Chromium/Electron apps (QQ, WeChat, Chrome, Edge, Brave, etc.) are shown from the dock, Mutter's ClutterOffscreenEffect reuses the offscreen FBO populated during the unminimize animation. The FBO was populated at intermediate (scaled) resolutions with whatever stale Wayland buffer the client still holds, resulting in blurry window content that persists until the mouse enters the window.
This is reproducible on GNOME 50 with Dash to Dock, 100% integer scaling, XWayland and native Wayland clients.
Root Cause
Fix
Force FBO invalidation by toggling the effect's enabled state (enabled=false destroys the offscreen, enabled=true + queue_repaint allocates a fresh FBO with the current window buffer).
Two trigger paths:
Also adds periodic shader refreshes for Chromium windows on fractional-scaled displays.
Non-Chromium windows are completely unaffected — updateEffectWithFboInvalidate skips the toggle for them.