feat: resolve built in constants in graph without environment#2519
Merged
EagleoutIce merged 3 commits intoMay 29, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables graph-only resolution of built-in constants by representing resolved built-in constant targets as value vertices carrying their abstract value.
Changes:
- Adds optional precomputed
valuestorage to value vertices. - Inserts value vertices for built-in constant read targets.
- Updates alias tracking and tests to resolve
T,F, andTRUEwithout an environment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/dataflow/graph/vertex.ts |
Extends value vertices with an optional abstract Value. |
src/dataflow/internal/process/functions/call/built-in/built-in-expression-list.ts |
Adds synthetic value vertices for built-in constant read targets. |
src/dataflow/eval/resolve/alias-tracking.ts |
Uses stored value-vertex values before falling back to AST-id lookup. |
test/functionality/dataflow/main/atomic/dataflow-atomic.test.ts |
Adds graph expectations for built-in constant aliases. |
test/functionality/dataflow/environments/resolve.test.ts |
Adds graph-only and environment resolution tests for built-in constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EagleoutIce
deleted the
2518-resolve-built-in-constants-in-resolveidtovalue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.