Skip to content

Migrate tool/generator test to ConfigParser.loadConfig and clean up workflow#186

Merged
reidbaker merged 9 commits into
flutter:mainfrom
reidbaker:migrate-generator-skills-test-2026-07-20
Jul 20, 2026
Merged

Migrate tool/generator test to ConfigParser.loadConfig and clean up workflow#186
reidbaker merged 9 commits into
flutter:mainfrom
reidbaker:migrate-generator-skills-test-2026-07-20

Conversation

@reidbaker

@reidbaker reidbaker commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Update the style of dart_skills_lint validation to the most up to date pattern. That pattern is to use the yaml config style so that cli invocations and dart test invocations do the same thing with the exception of custom rules which can only be invoked with dart test.

github actions are updated because the cli run is now duplicated work.

Skills are updated because I found an easy to add false negative.

Error on the consumers had the wrong kevmoo repo listed because I did not have it cloned locally. Once I did the repo was corrected.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configuration file dart_skills_lint.yaml and updates lint_skills_test.dart to load this configuration dynamically using ConfigParser.loadConfig(). Feedback on the changes highlights a potential issue where running the test from the repository root (such as in CI/CD environments) could cause the configuration to load silently as empty, resulting in a false-positive passing test. It is recommended to assert that the loaded configuration is not empty and to handle directory path resolution dynamically.

Comment thread tool/generator/test/lint_skills_test.dart
@reidbaker
reidbaker requested a review from johnpryan July 20, 2026 20:41
@reidbaker
reidbaker marked this pull request as ready for review July 20, 2026 20:41
@reidbaker
reidbaker requested review from camsim99 and jwren and removed request for johnpryan and jwren July 20, 2026 20:42

@camsim99 camsim99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@reidbaker
reidbaker merged commit 52a9593 into flutter:main Jul 20, 2026
17 checks passed
@reidbaker
reidbaker deleted the migrate-generator-skills-test-2026-07-20 branch July 20, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants