Migrate tool/generator test to ConfigParser.loadConfig and clean up workflow#186
Merged
reidbaker merged 9 commits intoJul 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration file dart_skills_lint.yaml and updates lint_skills_test.dart to load this configuration dynamically using ConfigParser.loadConfig(). Feedback on the changes highlights a potential issue where running the test from the repository root (such as in CI/CD environments) could cause the configuration to load silently as empty, resulting in a false-positive passing test. It is recommended to assert that the loaded configuration is not empty and to handle directory path resolution dynamically.
…pty assertion when loading config
reidbaker
marked this pull request as ready for review
July 20, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the style of dart_skills_lint validation to the most up to date pattern. That pattern is to use the yaml config style so that cli invocations and dart test invocations do the same thing with the exception of custom rules which can only be invoked with dart test.
github actions are updated because the cli run is now duplicated work.
Skills are updated because I found an easy to add false negative.
Error on the consumers had the wrong kevmoo repo listed because I did not have it cloned locally. Once I did the repo was corrected.