docs(styling): document and test-prove the recipe caller-append merge contract by anilcancakir · Pull Request #146 · fluttersdk/wind

anilcancakir · 2026-07-07T14:06:08Z

What (WIND-1)

Verifies and documents that WindRecipe/WindSlotRecipe already merge a caller className correctly: the recipe only appends the caller className last, and the conflict with a base token is resolved one layer down, at parse time, by WindParser's per-family last-wins. There is intentionally no Dart twMerge/cn port.

This PR adds no runtime code. It locks the contract with tests and documents it.

Why

The recipe merge behavior was correct but undocumented, and the "className replaces the recipe" anti-pattern (a consumer bug, not a wind defect) needed to be stated on the record so consumers do not re-implement a twMerge that wind does not need.

Changes

test/recipe/wind_recipe_test.dart: proves WindRecipe(base: 'w-1/2')(className: 'w-full') emits w-1/2 w-full (caller appended last, order preserved, no dedup).
test/parser/parsers/sizing_parser_test.dart: proves the appended w-full wins at parse time (widthFactor resolves to 1.0).
doc/styling/wind-recipe.md, skills/wind-ui/SKILL.md: document the caller-append contract and note the REPLACE anti-pattern lives in consumer components, not wind.

Verification

dart analyze clean, dart format clean, flutter test green.

…olves it (WIND-1)

… (WIND-1)

coderabbitai · 2026-07-07T14:06:19Z

Warning

Review limit reached

@anilcancakir, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d50d9c86-bc9a-446a-bc79-6c854c6864fd

📥 Commits

Reviewing files that changed from the base of the PR and between 7dcb980 and 3a760f3.

📒 Files selected for processing (5)

CHANGELOG.md
doc/styling/wind-recipe.md
skills/wind-ui/SKILL.md
test/parser/parsers/sizing_parser_test.dart
test/recipe/wind_recipe_test.dart

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch docs/recipe-caller-append-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

This PR locks in and documents Wind’s “caller-append” merge contract for WindRecipe/WindSlotRecipe, showing that caller-provided className is appended last (no dedupe/twMerge) and that conflicts are resolved at parse time via per-family last-wins in WindParser/parsers.

Changes:

Added a recipe-level test proving the emitted class string preserves both conflicting tokens with caller appended last.
Added a parser-level test proving the trailing (caller) sizing token wins (w-full overrides w-1/2 at parse time).
Documented the contract in user docs and the wind-ui skill, plus recorded it in CHANGELOG.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/recipe/wind_recipe_test.dart	Adds a test proving `WindRecipe` appends caller `className` last without merging/deduping.
test/parser/parsers/sizing_parser_test.dart	Adds a test proving parse-time last-wins makes appended `w-full` win over base `w-1/2`.
skills/wind-ui/SKILL.md	Documents the caller-append/no-twMerge recipe contract for the skill surface.
doc/styling/wind-recipe.md	Documents the caller-append contract and explains parse-time conflict resolution.
CHANGELOG.md	Adds an Unreleased entry describing the newly documented/test-proved contract.

codecov · 2026-07-07T14:10:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

… note consumer-agnostic Addresses PR review: the parse-time-resolution sentence now cites WindParser.findAndGroupClasses / SizingParser.parse (the recipe rationale reference moves to the no-twMerge sentence where it belongs), and the className-REPLACE anti-pattern note no longer names a specific downstream project.

anilcancakir · 2026-07-07T14:25:42Z

@coderabbitai review

coderabbitai · 2026-07-07T14:25:48Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

…line range

anilcancakir · 2026-07-07T14:36:53Z

@coderabbitai review

coderabbitai · 2026-07-07T14:36:59Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

anilcancakir added 2 commits July 7, 2026 17:05

test(recipe): prove caller className appends and parser last-wins res…

5783908

…olves it (WIND-1)

docs(styling): document the recipe caller-append contract, no twMerge…

2a7076d

… (WIND-1)

Copilot AI review requested due to automatic review settings July 7, 2026 14:06

Copilot started reviewing on behalf of anilcancakir July 7, 2026 14:06 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread doc/styling/wind-recipe.md Outdated

Comment thread doc/styling/wind-recipe.md Outdated

anilcancakir requested a review from Copilot July 7, 2026 14:27

Copilot started reviewing on behalf of anilcancakir July 7, 2026 14:28 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread doc/styling/wind-recipe.md Outdated

docs(styling): reference wind_recipe.dart by file, not a drift-prone …

3a760f3

…line range

anilcancakir merged commit 41b23a3 into master Jul 7, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(styling): document and test-prove the recipe caller-append merge contract#146

docs(styling): document and test-prove the recipe caller-append merge contract#146
anilcancakir merged 4 commits into
masterfrom
docs/recipe-caller-append-contract

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Review limit reached

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 7, 2026

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

anilcancakir commented Jul 7, 2026

What (WIND-1)

Why

Changes

Verification

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 7, 2026

Codecov Report

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading